-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bon eval #111
Conversation
Will give a more thorough review once the data is moved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is getting closer. High level comments also shared on slack.
- We still have more jsons to move to huggingface
- Make all of this happen in the existing
scripts/run_bon.py
. - To do so, most of the functions can be in
rewardbench/bon_utils.py
- We can have duplicated scripts in analysis in case there's an error and someone wants to re-run alpacaeval conversion
- Code cleaning, adding license, removing unnecessary things
Mostly, I want to make this first-party supported in the repo, not a separate folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More comments attached.
@@ -0,0 +1,2 @@ | |||
bon_data/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need these? Can we just change filepaths to align with existing scripts? Not sure they need to be different.
No description provided.